mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhitao Li" <zhitaoli...@gmail.com>
Subject Re: Review Request 40429: Report executor exit to framework schedulers.
Date Thu, 24 Dec 2015 20:30:31 GMT


> On Dec. 18, 2015, 12:04 p.m., Adam B wrote:
> > CHANGELOG, line 104
> > <https://reviews.apache.org/r/40429/diff/4/?file=1163761#file1163761line104>
> >
> >     You're modifying the 0.26 Release Notes, but this is going into 0.27 now.
> >     If this is worth calling out as an "API Change" (probably), then you should
add it to an "API Changes" section of `Release Notes - Mesos - Version 0.27.0 (WIP)`.
> >     If not, then you don't have to change this file at all. (The 0.27 release manager
will fill in the CHANGELOG prior to release.)

Thanks. I was indeed confused with the version when touching this file. Will comment in "API
Changes" by indicating that executorLost is going to be actually called from 0.27.


> On Dec. 18, 2015, 12:04 p.m., Adam B wrote:
> > src/sched/sched.cpp, lines 215-217
> > <https://reviews.apache.org/r/40429/diff/4/?file=1163767#file1163767line215>
> >
> >     Why did you swap these? I think Vinod wanted you to swap ExitedExecutorMessage::slave_id
and ExitedExecutorMessage::executor_id instead.

Must have mistread the comment. Will fix both.


> On Dec. 18, 2015, 12:04 p.m., Adam B wrote:
> > src/tests/fault_tolerance_tests.cpp, line 294
> > <https://reviews.apache.org/r/40429/diff/4/?file=1163768#file1163768line294>
> >
> >     This EXPECT should be set up before you call containerizer.destroy(), in case
the destroy is so fast that it calls executorLost before you can set up the expectation.

Thanks for pointing out that. Will fix.


- Zhitao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40429/#review110348
-----------------------------------------------------------


On Dec. 24, 2015, 8:29 p.m., Zhitao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40429/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2015, 8:29 p.m.)
> 
> 
> Review request for mesos, Adam B and Vinod Kone.
> 
> 
> Bugs: MESOS-313
>     https://issues.apache.org/jira/browse/MESOS-313
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Report executor exit to framework schedulers. This is a MVP to start the work of notifying
scheduler on scheduler refresh.
> 
> Next step would be sending this message reliabily, and/or splitting Event::FAILURE for
slave failure and executor termination.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG ea8f629f5543a8be61d162779c2b5b12f66cea79 
>   docs/app-framework-development-guide.md 4a43a93d080bdac37b8aee91748fea7552a1cc67 
>   docs/upgrades.md aebdc1e1b7a73c93b5a14867214eb852de89ad24 
>   include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 
>   src/java/src/org/apache/mesos/Scheduler.java 4f048830a2c47f747033c60730cc770cb2578815

>   src/python/interface/src/mesos/interface/__init__.py 4be502fd83029ad5fc798696caf9e27fd95f7482

>   src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c 
>   src/tests/fault_tolerance_tests.cpp ba657d0e1d8515cffd1b37925bf91a84b2feaef1 
>   src/tests/gc_tests.cpp f939d27c58177fba052fbcd9d6c9a572d052df52 
>   src/tests/master_slave_reconciliation_tests.cpp 9afa826006fa7129da1a9c1ac8c389c0e051f717

>   src/tests/master_tests.cpp 865fa4a71f4bae2a218cd2c4e10873222d1ea3c4 
>   src/tests/scheduler_event_call_tests.cpp 03f0332ef75bbe7c4947bd6daf55d40384570f18 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/40429/diff/
> 
> 
> Testing
> -------
> 
> Modified test for SchedulerDriverEventTest.Failure, which verifies that MockScheduler::executorLost
is invoked.
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message