mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).
Date Tue, 22 Dec 2015 17:52:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41511/
-----------------------------------------------------------

(Updated Dec. 22, 2015, 5:52 p.m.)


Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Park.


Changes
-------

Addressed comments.


Bugs: MESOS-4183
    https://issues.apache.org/jira/browse/MESOS-4183


Repository: mesos


Description
-------

Where possible move `operator<<` definitions and functions using streams to ".cpp" files
and include `<iosfwd>` in ".hpp"s. Also remove unused I/O includes, add necessary includes,
clean up `std::` prefixes and blank lines.


Diffs (updated)
-----

  include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
  include/mesos/type_utils.hpp b370b5180e71ed246fa09bf0fe119dfa946d0b08 
  include/mesos/v1/mesos.hpp 80e76040de77e65b20f10b0465124ab86c1feab6 
  include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
  include/mesos/v1/values.hpp a160bd4d49d53fd2f794f36fea69ea99a455af09 
  include/mesos/values.hpp 58af972186d7156660eac742b41501ce420cefe9 
  src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 
  src/common/type_utils.cpp c6c9ba7d1bfc6e6202b9e3ff94a74711e3602d6f 
  src/v1/mesos.cpp 13a58baf086ef3aaf46abcf7f58b71b7e2639728 
  src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 

Diff: https://reviews.apache.org/r/41511/diff/


Testing
-------

make check on Mac OS 10.10.4.


Thanks,

Alexander Rukletsov


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message