mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 41514: Accepted a single JSON object for quota set request.
Date Mon, 21 Dec 2015 23:34:12 GMT


> On Dec. 21, 2015, 10:03 p.m., Guangya Liu wrote:
> > src/master/quota_handler.cpp, lines 358-359
> > <https://reviews.apache.org/r/41514/diff/2/?file=1173817#file1173817line358>
> >
> >     What will happen if end user input TRUE, True, FALSE, False? Shall we document
those keyword in quota documentation?

We lower-case the input before checking with this allowed set.


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41514/#review111543
-----------------------------------------------------------


On Dec. 21, 2015, 1:27 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41514/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 1:27 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and Joris Van
Remoortere.
> 
> 
> Bugs: MESOS-3960
>     https://issues.apache.org/jira/browse/MESOS-3960
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> POST request to "/quota" requires a single JSON object as opposed to key-value pairs
encoded in a string.
> 
> 
> Diffs
> -----
> 
>   src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 
>   src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 
>   src/tests/role_tests.cpp 2c5f68ccaac7e9a37345e2f331d1bc35cae77736 
> 
> Diff: https://reviews.apache.org/r/41514/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message