mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 41294: Logger Module: Adds the ContainerLogger into the DockerContainerizer.
Date Sun, 20 Dec 2015 23:17:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41294/#review111430
-----------------------------------------------------------


We shouldn't pass `ContainerLogger` into `Docker` while also keeping it `Owned` inside `DockerContainerizer`.
It's confusing to people, we're explicitly breaking the contract of `Owned`.

Instead, why not change the `Docker::run` to take `Subprocess::IO` instead of the stdout/stderr
paths? Could we make that work?

- Benjamin Hindman


On Dec. 15, 2015, 8:41 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41294/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 8:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, haosdent huang, and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4137
>     https://issues.apache.org/jira/browse/MESOS-4137
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `DockerContainerizer` creates and initializes its own `ContainerLogger` and passes
it into the `Docker` wrapper.
> 
> The `ContainerLogger` is used before launching executors, in two two call sites depending
on whether the agent is running in a container or not.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb 
>   src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a 
>   src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e 
>   src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e 
> 
> Diff: https://reviews.apache.org/r/41294/diff/
> 
> 
> Testing
> -------
> 
> Tests will be modified and run later in the review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message