mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 40838: Environment variable: Implemented `Env` specified in docker image returned from docker pull.
Date Sat, 19 Dec 2015 01:18:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40838/#review111332
-----------------------------------------------------------



src/docker/docker.cpp (line 363)
<https://reviews.apache.org/r/40838/#comment171463>

    Remove extra line.



src/docker/docker.cpp (line 403)
<https://reviews.apache.org/r/40838/#comment171464>

    Do we have a test for this?


- Timothy Chen


On Dec. 9, 2015, 6:41 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40838/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2015, 6:41 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Timothy Chen.
> 
> 
> Bugs: MESOS-4046
>     https://issues.apache.org/jira/browse/MESOS-4046
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Environment variable: Implemented `Env` specified in docker image returned from docker
pull.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb 
>   src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a 
> 
> Diff: https://reviews.apache.org/r/40838/diff/
> 
> 
> Testing
> -------
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message