mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 40255: [5/7] Added framework authorization for persistent volumes.
Date Fri, 18 Dec 2015 19:59:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40255/#review111233
-----------------------------------------------------------

Ship it!



src/master/master.cpp (line 3425)
<https://reviews.apache.org/r/40255/#comment171326>

    Thanks!



src/tests/persistent_volume_tests.cpp (line 751)
<https://reviews.apache.org/r/40255/#comment171330>

    If you pause the clock, looks like this is not needed?



src/tests/persistent_volume_tests.cpp (line 906)
<https://reviews.apache.org/r/40255/#comment171335>

    Ditto. Using default value sounds ok to me since clock is paused.



src/tests/persistent_volume_tests.cpp (lines 969 - 970)
<https://reviews.apache.org/r/40255/#comment171338>

    I would move this up right below 'acceptOffers' to have better flow (first volume is created,
and then we receive another offer). Here, and every other occurances.



src/tests/persistent_volume_tests.cpp (lines 980 - 981)
<https://reviews.apache.org/r/40255/#comment171341>

    Can you move this up and right below `AWAIT_READY(checkpointResources1)`? Here and every
other occurances.



src/tests/persistent_volume_tests.cpp (line 1007)
<https://reviews.apache.org/r/40255/#comment171342>

    Ditto.



src/tests/persistent_volume_tests.cpp (lines 1016 - 1018)
<https://reviews.apache.org/r/40255/#comment171343>

    Ditto.



src/tests/persistent_volume_tests.cpp (line 1069)
<https://reviews.apache.org/r/40255/#comment171345>

    Why this given the clock is paused.



src/tests/persistent_volume_tests.cpp (line 1138)
<https://reviews.apache.org/r/40255/#comment171346>

    +1 on using suppressOffer and reviveOffer


- Jie Yu


On Dec. 18, 2015, 10:10 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40255/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 10:10 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3065
>     https://issues.apache.org/jira/browse/MESOS-3065
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added framework authorization for persistent volumes.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 470b542729b01f41fc6a2e601a7a6c3d0c5353d5 
>   src/tests/persistent_volume_tests.cpp 01b3c13751a5558d5f06edb8f650c8644dc54486 
> 
> Diff: https://reviews.apache.org/r/40255/diff/
> 
> 
> Testing
> -------
> 
> This is the fifth in a chain of 7 patches. New tests were added to `persistent_volume_tests.cpp`
in order to test a framework attempting both successful and failed authorizations for `CREATE`
and `DESTROY` offer operations. `make check` was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message