mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 41510: Cleaned up STL I/O includes in external containerizer.
Date Fri, 18 Dec 2015 13:44:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41510/#review111180
-----------------------------------------------------------

Ship it!



src/slave/containerizer/external_containerizer.cpp (line 22)
<https://reviews.apache.org/r/41510/#comment171280>

    Only focussing on I/O related headers, `iomanip` is unused here as well and should be
removed.


- Benjamin Bannier


On Dec. 17, 2015, 2:37 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41510/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 2:37 p.m.)
> 
> 
> Review request for mesos, Michael Park and Till Toenshoff.
> 
> 
> Bugs: MESOS-4183
>     https://issues.apache.org/jira/browse/MESOS-4183
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Remove unused I/O includes, clean up blank lines and include order.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/external_containerizer.hpp a5b4079a8f89c0c144468b42787c6cec78692d63

>   src/slave/containerizer/external_containerizer.cpp 04cf31e005c2be8af0f80dbf856bb94b2ab5351a

> 
> Diff: https://reviews.apache.org/r/41510/diff/
> 
> 
> Testing
> -------
> 
> make check on Mac OS 10.10.4.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message