mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 40345: [1/4] Quota Authorization: Added "SetQuota" message to ACL protobuf.
Date Thu, 17 Dec 2015 09:34:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40345/#review110925
-----------------------------------------------------------

Ship it!



include/mesos/authorizer/authorizer.proto (line 127)
<https://reviews.apache.org/r/40345/#comment170921>

    Not yours, but would it make sense to group the ACLs (and add some spacing)?


- Joerg Schad


On Dec. 4, 2015, 1:53 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40345/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 1:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van Remoortere,
and Till Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Added "SetQuota" message to ACL protobuf.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.proto 74fcc86d3c92cb3aa27e45b647b1653705b3201c

> 
> Diff: https://reviews.apache.org/r/40345/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message