mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 41188: Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages to HTTP endpoints
Date Thu, 17 Dec 2015 00:12:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41188/#review110804
-----------------------------------------------------------


LGTM, Just one thing to confirm around nested `labels` field in expected JSON.


src/tests/common/http_tests.cpp (lines 72 - 76)
<https://reviews.apache.org/r/41188/#comment170801>

    Can you modify this based on my earlier comment around `Label` in the earlier test.



src/tests/common/http_tests.cpp (lines 130 - 140)
<https://reviews.apache.org/r/41188/#comment170797>

    Can you confirm that other objects that have labels that are exposed via `/state` endpoint
also have a nested `labels` mapping ?
    
    AFAICT, this is an artifact of us using the Protobuf to JSON converters when we should
have just used the `model(...)` functions.



src/tests/slave_tests.cpp (line 2223)
<https://reviews.apache.org/r/41188/#comment170799>

    you should be able to use `APPLICATION_JSON` defined in `include/mesos/http.hpp`


- Anand Mazumdar


On Dec. 15, 2015, 9:13 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41188/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 9:13 p.m.)
> 
> 
> Review request for mesos, Adam B and Anand Mazumdar.
> 
> 
> Bugs: MESOS-3962
>     https://issues.apache.org/jira/browse/MESOS-3962
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Providing JSON bindings to so that mesos modules can expose DiscoveryInfo protobuf messages
to HTTP endpoints
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp d1b1158c0a80d72c32c9b28977043b6be2295239 
>   src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 
>   src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
> 
> Diff: https://reviews.apache.org/r/41188/diff/
> 
> 
> Testing
> -------
> 
> make check.
> Added Unit tests to verify setting of DiscoveryInfo in state.json in slave. 
> Also added Unit test to test that DiscoveryInfo gets exposed in master when TaskInfo
protobuf is converted to JSON objects.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message