mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 41386: Logger Module: Add regression test for docker containerizer logging to sandbox.
Date Tue, 15 Dec 2015 17:20:53 GMT


> On Dec. 14, 2015, 8:08 p.m., Timothy Chen wrote:
> > src/tests/container_logger_tests.cpp, line 158
> > <https://reviews.apache.org/r/41386/diff/1/?file=1164291#file1164291line158>
> >
> >     Not against adding more tests, but we already have an identical test in the
docker containerizer tests

Ah, I did not notice.  (`DockerContainerizerTest.ROOT_DOCKER_Logs`, right?)


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41386/#review110399
-----------------------------------------------------------


On Dec. 14, 2015, 6:26 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41386/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2015, 6:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4137
>     https://issues.apache.org/jira/browse/MESOS-4137
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `ContainerLoggerTest.ROOT_DOCKER_DefaultToSandbox` is a regression test which checks
the existing logging behavior, in which the docker executor and command task are both logged
to the same file in the sandbox.
> 
> 
> Diffs
> -----
> 
>   src/tests/container_logger_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41386/diff/
> 
> 
> Testing
> -------
> 
> make check (Centos7)
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message