mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 41320: Clarified Subprocess PIPE usage in Subprocess tests.
Date Sun, 13 Dec 2015 01:13:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41320/#review110107
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 12, 2015, 11:11 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41320/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2015, 11:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently we use PIPE() in many places where it is not necessary. This
> switches these instances to use the default (re-inherit the parent FD).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 869b920b4f25a74a69813ac4777e843d38300cbd

> 
> Diff: https://reviews.apache.org/r/41320/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message