mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 38877: Added functionality for Subscribe/Subscribed workflow for HTTP executors
Date Wed, 02 Dec 2015 22:24:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/#review108391
-----------------------------------------------------------


I see a very basic test in the next review. Are you planning to write more comprehensive tests?
Is that plan to templatize slave recovery tests for both pid based and http executors?


src/slave/slave.cpp (lines 2414 - 2415)
<https://reviews.apache.org/r/38877/#comment167839>

    I see that 'RECOVERING' is a possible state in `registerExecutor()`. Is that not possible
for http executors?



src/slave/slave.cpp (line 2450)
<https://reviews.apache.org/r/38877/#comment167841>

    s/retry/retried/



src/slave/slave.cpp (line 2454)
<https://reviews.apache.org/r/38877/#comment167843>

    i don't think 'in lieu of' is correct here. just remove the second part starting from
"in lieu of...".



src/slave/slave.cpp (line 2475)
<https://reviews.apache.org/r/38877/#comment167844>

    s/http/HTTP/


- Vinod Kone


On Nov. 30, 2015, 3:56 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38877/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 3:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
> 
> 
> Bugs: MESOS-3515
>     https://issues.apache.org/jira/browse/MESOS-3515
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the functionality for executors to `Subscribe` via the `api/v1/executor`
endpoint. It also stores a marker file as part of the `Subscribe` call if framework `checkpointing`
is enabled. This can then be used by the agent when recovering to wait for reconnecting back
with the executor.
> 
> 
> Diffs
> -----
> 
>   src/slave/http.cpp c3247f17e9faed32a46d3ab9ee83c399cd2c8d5e 
>   src/slave/slave.hpp 5ee133ae52998d05c8afabb2ade7095e363c75c5 
>   src/slave/slave.cpp 9055f2a789cb19f3579c15a379ea505dfef0578c 
> 
> Diff: https://reviews.apache.org/r/38877/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message