mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Review Request 40880: Fix flaky MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery test.
Date Wed, 02 Dec 2015 20:44:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40880/
-----------------------------------------------------------

Review request for mesos, Bernd Mathiske, Artem Harutyunyan, and Till Toenshoff.


Bugs: MESOS-4047
    https://issues.apache.org/jira/browse/MESOS-4047


Repository: mesos


Description
-------

`MesosContainerizerSlaveRecoveryTest.ResourceStatistics` has very similar logic for restarting
an agent, re-registering the executor, and even getting `ResourceStatistics`.  But `MesosContainerizerSlaveRecoveryTest.ResourceStatistics`
is stable.

This patch updates the flaky test's wait-for-agent-recovery logic to match the stable test.


Diffs
-----

  src/tests/containerizer/memory_pressure_tests.cpp e18b971c4df26c9b9c103ca73bdad4fd400d6c02


Diff: https://reviews.apache.org/r/40880/diff/


Testing
-------

On Ubuntu 14:
`make check`
`sudo bin/mesos-tests.sh --gtest_filter="*MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery*"
--gtest_repeat=-1 --gtest_break_on_failure`

^ Ran the above until satisfied.


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message