mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <klaus1982...@gmail.com>
Subject Re: Review Request 40631: Move "using mesos::fetcher::FetcherInfo" into internal namespace in "fetcher.hpp"
Date Tue, 01 Dec 2015 13:13:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40631/
-----------------------------------------------------------

(Updated Dec. 1, 2015, 9:13 p.m.)


Review request for mesos, Benjamin Bannier, Joseph Wu, and Michael Park.


Changes
-------

Correct the code diff.


Bugs: MESOS-3963
    https://issues.apache.org/jira/browse/MESOS-3963


Repository: mesos


Description
-------

According to the google code style, the using should be used in internal namespace in header
files. Grep the header files, only fetcher.hpp deserved a path.


> You may use a using-declaration anywhere in a .cc file (including in the global namespace),
and in functions, methods, classes, or within internal namespaces in .h files.

>Do not use using-declarations in .h files except in explicitly marked internal-only namespaces,
because anything imported into a namespace in a .h file becomes part of the public API exported
by that file.

```
// OK in .cc files.
// Must be in a function, method, internal namespace, or
// class in .h files.
using ::foo::bar;
```


Diffs (updated)
-----

  src/slave/containerizer/fetcher.hpp 78e7d14 
  src/tests/mesos.hpp a2a76f5 

Diff: https://reviews.apache.org/r/40631/diff/


Testing
-------

make && make check


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message