Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B0C6418B1E for ; Sun, 22 Nov 2015 17:18:00 +0000 (UTC) Received: (qmail 22320 invoked by uid 500); 22 Nov 2015 17:18:00 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 22292 invoked by uid 500); 22 Nov 2015 17:18:00 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 22275 invoked by uid 99); 22 Nov 2015 17:18:00 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Nov 2015 17:18:00 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1EDB21DDBBA; Sun, 22 Nov 2015 17:17:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1011019600887801586==" MIME-Version: 1.0 Subject: Re: Review Request 40399: Quota: Introduced quota registry operations. From: "Joris Van Remoortere" To: "Joris Van Remoortere" , "Joerg Schad" , "Bernd Mathiske" , "Joseph Wu" Cc: "Alexander Rukletsov" , "mesos" Date: Sun, 22 Nov 2015 17:17:59 -0000 Message-ID: <20151122171759.26797.77025@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joris Van Remoortere" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40399/ X-Sender: "Joris Van Remoortere" References: <20151122170304.26798.62413@reviews.apache.org> In-Reply-To: <20151122170304.26798.62413@reviews.apache.org> Reply-To: "Joris Van Remoortere" X-ReviewRequest-Repository: mesos --===============1011019600887801586== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40399/#review107508 ----------------------------------------------------------- Ship it! src/master/quota.cpp (lines 70 - 85) We don't need to keep track of changed here right? src/master/quota.cpp (line 78) Missing period. - Joris Van Remoortere On Nov. 22, 2015, 5:03 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40399/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2015, 5:03 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, and Joseph Wu. > > > Bugs: MESOS-3165 > https://issues.apache.org/jira/browse/MESOS-3165 > > > Repository: mesos > > > Description > ------- > > Follow up of https://reviews.apache.org/r/38958 > > > Diffs > ----- > > src/master/quota.hpp 8fc984003762a339a796b7a516362e21dab0a6e5 > src/master/quota.cpp 835b191460d86e912ffdac8160459b4a0643bd88 > > Diff: https://reviews.apache.org/r/40399/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > > --===============1011019600887801586==--