Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4970918B40 for ; Fri, 20 Nov 2015 11:14:46 +0000 (UTC) Received: (qmail 78585 invoked by uid 500); 20 Nov 2015 11:14:46 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 78560 invoked by uid 500); 20 Nov 2015 11:14:46 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 78540 invoked by uid 99); 20 Nov 2015 11:14:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Nov 2015 11:14:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BE7942E2ABE; Fri, 20 Nov 2015 11:14:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8205288256384356624==" MIME-Version: 1.0 Subject: Re: Review Request 39449: Documented order of includes. From: "Jan Schlicht" To: "Michael Park" , "Marco Massenzio" Cc: "Joerg Schad" , "Jan Schlicht" , "mesos" Date: Fri, 20 Nov 2015 11:14:44 -0000 Message-ID: <20151120111444.6715.29602@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jan Schlicht" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39449/ X-Sender: "Jan Schlicht" References: <20151103215613.16291.73110@reviews.apache.org> In-Reply-To: <20151103215613.16291.73110@reviews.apache.org> Reply-To: "Jan Schlicht" X-ReviewRequest-Repository: mesos --===============8205288256384356624== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 3, 2015, 10:56 p.m., Joerg Schad wrote: > > docs/c++-style-guide.md, line 262 > > > > > > This should be the first include (see my other comments and the Google Styleguide ( https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes) :-)). Yes, it's also my opinion that the related header should be included first. After presenting this at the dev-list there were no comments against it. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39449/#review104986 ----------------------------------------------------------- On Oct. 19, 2015, 11:29 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39449/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2015, 11:29 p.m.) > > > Review request for mesos, Marco Massenzio and Michael Park. > > > Bugs: MESOS-2275 > https://issues.apache.org/jira/browse/MESOS-2275 > > > Repository: mesos > > > Description > ------- > > Documented order of includes. > > > Diffs > ----- > > docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad > > Diff: https://reviews.apache.org/r/39449/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > > --===============8205288256384356624==--