Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 24B5B18A66 for ; Mon, 16 Nov 2015 12:55:13 +0000 (UTC) Received: (qmail 29598 invoked by uid 500); 16 Nov 2015 12:55:13 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 29575 invoked by uid 500); 16 Nov 2015 12:55:13 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 29560 invoked by uid 99); 16 Nov 2015 12:55:12 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Nov 2015 12:55:12 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1A5002E1FF5; Mon, 16 Nov 2015 12:55:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6811835521550598952==" MIME-Version: 1.0 Subject: Re: Review Request 39289: Quota: Added authorization of quota requests. From: "Mesos ReviewBot" To: "Till Toenshoff" , "Alexander Rukletsov" , "Alexander Rojas" Cc: "mesos" , "Jan Schlicht" , "Mesos ReviewBot" Date: Mon, 16 Nov 2015 12:55:12 -0000 Message-ID: <20151116125512.19610.15932@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39289/ X-Sender: "Mesos ReviewBot" References: <20151116124151.19610.5584@reviews.apache.org> In-Reply-To: <20151116124151.19610.5584@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============6811835521550598952== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39289/#review106653 ----------------------------------------------------------- Bad patch! Reviews applied: [39211, 39018, 39102, 36913] Failed command: ./support/apply-review.sh -n -r 36913 Error: 2015-11-16 12:55:10 URL:https://reviews.apache.org/r/36913/diff/raw/ [7367/7367] -> "36913.patch" [1] error: patch failed: src/Makefile.am:511 error: src/Makefile.am: patch does not apply Failed to apply patch - Mesos ReviewBot On Nov. 16, 2015, 12:41 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39289/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 12:41 p.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till Toenshoff. > > > Bugs: MESOS-3862 > https://issues.apache.org/jira/browse/MESOS-3862 > > > Repository: mesos > > > Description > ------- > > Added authorization of quota requests. > > > Diffs > ----- > > docs/authorization.md f5ed75fcd0785fde38058917354fcf6d668dcccb > include/mesos/authorizer/authorizer.hpp d667a52f90f970a313580446a5a006cec4b5e25b > include/mesos/authorizer/authorizer.proto 86bbb45f9d91b4098a262e3e50a793f3bb39497e > include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d > src/authorizer/local/authorizer.hpp 32de102fd588f029882ef2222121ca83a7410c65 > src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 > src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/quota_handler.cpp PRE-CREATION > src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed > > Diff: https://reviews.apache.org/r/39289/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > > --===============6811835521550598952==--