Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F263918383 for ; Sun, 15 Nov 2015 11:25:21 +0000 (UTC) Received: (qmail 9830 invoked by uid 500); 15 Nov 2015 11:25:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 9807 invoked by uid 500); 15 Nov 2015 11:25:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 9793 invoked by uid 99); 15 Nov 2015 11:25:21 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Nov 2015 11:25:21 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DAA8828FE06; Sun, 15 Nov 2015 11:25:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7913180553907634429==" MIME-Version: 1.0 Subject: Re: Review Request 40327: mesos: Marked Boost as a "system" header. From: "Mesos ReviewBot" To: "Joris Van Remoortere" , "Benjamin Bannier" Cc: "Neil Conway" , "Mesos ReviewBot" , "mesos" Date: Sun, 15 Nov 2015 11:25:20 -0000 Message-ID: <20151115112520.19610.26816@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40327/ X-Sender: "Mesos ReviewBot" References: <20151115103153.19611.61346@reviews.apache.org> In-Reply-To: <20151115103153.19611.61346@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============7913180553907634429== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40327/#review106557 ----------------------------------------------------------- Patch looks great! Reviews applied: [40326, 40327] All tests passed. - Mesos ReviewBot On Nov. 15, 2015, 10:31 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40327/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2015, 10:31 a.m.) > > > Review request for mesos, Benjamin Bannier and Joris Van Remoortere. > > > Bugs: MESOS-3799 > https://issues.apache.org/jira/browse/MESOS-3799 > > > Repository: mesos > > > Description > ------- > > This instructs the compiler to ignore warnings in the Boost headers. This is > useful, because those headers often contain hard-to-silence warnings that are > not otherwise useful to display. See MESOS-3799. > > > Diffs > ----- > > src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa > > Diff: https://reviews.apache.org/r/40327/diff/ > > > Testing > ------- > > Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10. > > Note that the cmake build still emits boost-related warnings: I didn't try to fix this, since cmake emits other warnings that autotools suppresses (e.g., no-unused-local-typedefs). > > > Thanks, > > Neil Conway > > --===============7913180553907634429==--