Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5DF6518ACB for ; Tue, 10 Nov 2015 08:11:06 +0000 (UTC) Received: (qmail 86527 invoked by uid 500); 10 Nov 2015 08:11:06 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 86504 invoked by uid 500); 10 Nov 2015 08:11:06 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 86488 invoked by uid 99); 10 Nov 2015 08:11:05 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Nov 2015 08:11:05 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CF0C51D9EAB; Tue, 10 Nov 2015 08:11:05 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8920695428219747009==" MIME-Version: 1.0 Subject: Re: Review Request 38876: Added functionality to store a marker file to denote HTTP based executors From: "Ben Mahler" To: "Isabel Jimenez" , "Ben Mahler" , "Vinod Kone" Cc: "Anand Mazumdar" , "mesos" Date: Tue, 10 Nov 2015 08:11:05 -0000 Message-ID: <20151110081105.1680.47990@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38876/ X-Sender: "Ben Mahler" References: <20151107010745.1770.3036@reviews.apache.org> In-Reply-To: <20151107010745.1770.3036@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos --===============8920695428219747009== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38876/#review105807 ----------------------------------------------------------- Ship it! Thanks, just some small cleanups and we should be all set. Would you mind adding a bit more context to the description to explain more specifically what the marker is used for? src/slave/paths.hpp (line 185) How about getExecutorHttpMarkerPath per my other suggestion? src/slave/paths.cpp (line 53) How about just HTTP_MARKER_FILE and "http.marker" to make this more symettric with the libprocess pid file stuff? - Ben Mahler On Nov. 7, 2015, 1:07 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38876/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2015, 1:07 a.m.) > > > Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone. > > > Bugs: MESOS-3515 > https://issues.apache.org/jira/browse/MESOS-3515 > > > Repository: mesos > > > Description > ------- > > This change adds the relevant functionality to `src/slave/paths.cpp/hpp` to store a marker file to denote HTTP based executors. We create the file when `checkpointing` is enabled as part of handling the `Subscribe` request. This is then used by the agent when recovering to ascertain if the executor was connected via `HTTP` before the agent restart. > > > Diffs > ----- > > src/slave/paths.hpp f743fb4b1ca278fade9134e0ae8f6a6450d4a977 > src/slave/paths.cpp fb77e64a6da017d8c9a00916d8935b670da0d374 > > Diff: https://reviews.apache.org/r/38876/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > > --===============8920695428219747009==--