-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39781/#review108298
-----------------------------------------------------------
src/tests/module_tests.cpp (line 54)
<https://reviews.apache.org/r/39781/#comment167693>
Since there is only one item left, this needs to be reworded, e.g.
> .., we do th `dlopen()` the examplemodule library and ..
src/tests/module_tests.cpp (line 70)
<https://reviews.apache.org/r/39781/#comment167694>
Not yours, but this should really be a `static_cast<ModuleBase*>`.
src/tests/module_tests.cpp (line 77)
<https://reviews.apache.org/r/39781/#comment167695>
Since `TearDownTestCase` is effectively a fixture's dtr, both zeroing out `moduleBase`
(a raw ptr) and clearing `libraryDirectory` (just a `string`) do nothing; please consider
dropping.
src/tests/module_tests.cpp (line 112)
<https://reviews.apache.org/r/39781/#comment167696>
None of these functions need to be (mutating!) member functions if you simply inject `libraryDirectory`;
please consider converting them to free functions, e.g. implemented in an anon namespace in
this translation unit.
src/tests/module_tests.cpp
<https://reviews.apache.org/r/39781/#comment167697>
Good catch! Looks like we already call `expandName` in most places.
- Benjamin Bannier
On Nov. 26, 2015, 2:04 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39781/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 2:04 p.m.)
>
>
> Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and Till Toenshoff.
>
>
> Bugs: MESOS-3725
> https://issues.apache.org/jira/browse/MESOS-3725
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Update ModuleTest to not assume dynamic dlopen search.
>
>
> Diffs
> -----
>
> src/tests/module_tests.cpp 28c71b0c1960bad4933f86d35fe8a0248fef326e
>
> Diff: https://reviews.apache.org/r/39781/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> James Peach
>
>
|