mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.
Date Fri, 27 Nov 2015 18:11:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/
-----------------------------------------------------------

(Updated Nov. 27, 2015, 6:11 p.m.)


Review request for mesos, Bernd Mathiske and Till Toenshoff.


Bugs: MESOS-3579
    https://issues.apache.org/jira/browse/MESOS-3579


Repository: mesos


Description
-------

GNU tar-1.28 and earlier can relatively randomly misidentify
compressed files as uncompressed ones, and will then fail when
unpacking. Avoid compressed tar files in some tests where we know we
directly call the tar system command (in mesos-fetcher in this case).


Diffs
-----

  src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309 
  src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 

Diff: https://reviews.apache.org/r/40776/diff/


Testing
-------

`make check` and verified test does not fail in at least 1000 iterations.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message