mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.
Date Mon, 23 Nov 2015 00:37:48 GMT


> On Nov. 22, 2015, 9:50 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, lines 324-328
> > <https://reviews.apache.org/r/40351/diff/5/?file=1132084#file1132084line324>
> >
> >     We should set the quota before we rescind so that we avoid the race above ;-)
> >     Please add a comment as to why we want to do them in the new order.

Setting quota triggers allocation. I think we would like to rescind *before* we trigger the
allocation. If we first set then rescind, rescinded resources may be available only during
the next allocation cycle.


> On Nov. 22, 2015, 9:50 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, lines 180-181
> > <https://reviews.apache.org/r/40351/diff/5/?file=1132084#file1132084line180>
> >
> >     "Offers that do
> >       // not contribute to satisfying quota request will be rescinded regardless."
> >       Not sure what you mean here.

For example, if quota is for "disk" resource, we will still rescind an offer with "cpus" and
"mem" resources.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40351/#review107520
-----------------------------------------------------------


On Nov. 19, 2015, 5:15 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40351/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 5:15 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu,
and Qian Zhang.
> 
> 
> Bugs: MESOS-3912
>     https://issues.apache.org/jira/browse/MESOS-3912
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/40351/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message