mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 40268: Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.
Date Fri, 20 Nov 2015 19:19:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40268/
-----------------------------------------------------------

(Updated Nov. 20, 2015, 11:19 a.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Summary (updated)
-----------------

Libprocess Reinitialization: Change Socket::DEFAULT_KIND to return a non-static local value.


Bugs: MESOS-3820
    https://issues.apache.org/jira/browse/MESOS-3820


Repository: mesos


Description (updated)
-------

This is only needed for tests that utilize the test-only `process::reinitialize` function.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/socket.hpp ebee78909feb5a4032da68f51d08dbf11b03b332

  3rdparty/libprocess/src/socket.cpp 6ac834e7459f5958b7c788ccdc60cbed90530183 

Diff: https://reviews.apache.org/r/40268/diff/


Testing (updated)
-------

Some test cleanup issues were uncovered by this change; fixed here: https://reviews.apache.org/r/40453/


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message