mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39712: Serialize Docker Registry Responses as Protobuf
Date Thu, 19 Nov 2015 21:22:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39712/#review107240
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38901, 38919, 39712]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 19, 2015, 7:37 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39712/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 7:37 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3514
>     https://issues.apache.org/jira/browse/MESOS-3514
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Serialize Docker Registry Responses as Protobuf
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 3fd84e380f9393a6d46544fb7fc7d24bcb6256ac

>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp b17b1b6d9e053af8c80217ea322e99ccab957df1

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 7fca99a3b118b0ac06566455ef003daeef7d8157

>   src/tests/containerizer/provisioner_docker_tests.cpp 9ff27083be91985484960a0d48d909b5594937db

> 
> Diff: https://reviews.apache.org/r/39712/diff/
> 
> 
> Testing
> -------
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message