mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39614: Quota: Added Status Validation Tests.
Date Thu, 19 Nov 2015 14:59:10 GMT


> On Nov. 6, 2015, 1:13 a.m., Joseph Wu wrote:
> > src/tests/master_quota_tests.cpp, lines 732-734
> > <https://reviews.apache.org/r/39614/diff/2/?file=1106413#file1106413line732>
> >
> >     Have you considered merging this test with `AvailableResourcesMultipleAgents`?
> 
> Joerg Schad wrote:
>     In my opinion it is good to test both aspects seperatly from each other.

I think it's okay to merge as long as it's clear what fails. Same for situations when no quota
is set. Moreover, once we have a test with several quotas, we can check status of multiple
quotas as well.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39614/#review105343
-----------------------------------------------------------


On Nov. 19, 2015, 2:48 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39614/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 2:48 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Added Status Validation Tests.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39614/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message