mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.
Date Wed, 18 Nov 2015 11:20:07 GMT


> On Nov. 18, 2015, midnight, Michael Park wrote:
> > docs/home.md, line 40
> > <https://reviews.apache.org/r/40242/diff/2/?file=1125051#file1125051line40>
> >
> >     `s/for use by a role/for a role/`? `to be used by a role`?

Personally, I think "for use by a role" is the clearest way to phrase this.


> On Nov. 18, 2015, midnight, Michael Park wrote:
> > docs/reservation.md, lines 244-262
> > <https://reviews.apache.org/r/40242/diff/2/?file=1125053#file1125053line244>
> >
> >     Do these backslashes need to be removed in order for copy/paste to work?

Yes.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review106960
-----------------------------------------------------------


On Nov. 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
>     https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message