mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 40327: mesos: Marked Boost as a "system" header.
Date Sun, 15 Nov 2015 11:25:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40327/#review106557
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40326, 40327]

All tests passed.

- Mesos ReviewBot


On Nov. 15, 2015, 10:31 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40327/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2015, 10:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3799
>     https://issues.apache.org/jira/browse/MESOS-3799
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This instructs the compiler to ignore warnings in the Boost headers. This is
> useful, because those headers often contain hard-to-silence warnings that are
> not otherwise useful to display. See MESOS-3799.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
> 
> Diff: https://reviews.apache.org/r/40327/diff/
> 
> 
> Testing
> -------
> 
> Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10.
> 
> Note that the cmake build still emits boost-related warnings: I didn't try to fix this,
since cmake emits other warnings that autotools suppresses (e.g., no-unused-local-typedefs).
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message