mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39636: FreeBSD: Add basic support to stout
Date Sat, 14 Nov 2015 10:08:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39636/#review106542
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39634, 39635, 39636]

All tests passed.

- Mesos ReviewBot


On Nov. 14, 2015, 9:03 a.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39636/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 9:03 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-1563
>     https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> FreeBSD: Add basic support to stout
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp 6709f5e7f6233983f389203278a0e42694591230

>   3rdparty/libprocess/3rdparty/stout/include/stout/mac.hpp 9428717fac4655898d7768957f02937592e1a398

>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp e49783a438157706b1be9745436bf666f45cab8b

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/bootid.hpp 3f0bad6bba7297bcfd5e0787cf8cabdbb19257fe

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp a5719bdf26b59955e7c47b6c5677bb6e847358ab

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/sendfile.hpp 828c9c777b1b0e067c2551b79b9747a3cf4fb0aa

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/signals.hpp e9b05ef3b59fd068137cb12e36591de2d4a801a1

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/raw/environment.hpp 0a98e9e310d3931c2341053595b7d62f68214783

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp 8a8ede325cfe8f024e1be4db24b0c8118d18f359

>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp e26df59d9b837e1f4a4b92577f0a3de4b9076cb4

>   3rdparty/libprocess/3rdparty/stout/tests/dynamiclibrary_tests.cpp 4cc781bddbf7ee10cc0671f62d710fb4fa80e293

>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 8791cfe628563b25ac86a8170966d458c3a9c0c8

> 
> Diff: https://reviews.apache.org/r/39636/diff/
> 
> 
> Testing
> -------
> 
> make check on ubuntu 14.04
> 
> gmake check on FreeBSD 10.2 (failing, log attached)
> 
> 
> File Attachments
> ----------------
> 
> check.log
>   https://reviews.apache.org/media/uploaded/files/2015/10/25/e661fec8-b342-440f-9b66-85bf0dd13fee__check.log
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message