mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 39985: [1/5] Introduced ACL protobuf definitions for dynamic reservation.
Date Fri, 13 Nov 2015 23:11:40 GMT


> On Nov. 13, 2015, 9:59 p.m., Jie Yu wrote:
> > include/mesos/authorizer/authorizer.proto, line 75
> > <https://reviews.apache.org/r/39985/diff/3/?file=1120023#file1120023line75>
> >
> >     Can we call it ReserveResources to match other ACLs? (also, in case we have
other things that we want to reserve in the future).

Thanks Jie, good call! I'm currently updating the other patches in the chain to accomodate
this change.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39985/#review106509
-----------------------------------------------------------


On Nov. 13, 2015, 11:11 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39985/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 11:11 p.m.)
> 
> 
> Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3062
>     https://issues.apache.org/jira/browse/MESOS-3062
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced ACL protobuf definitions for dynamic reservation.
> Note: this review is continued from https://reviews.apache.org/r/37002/
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.proto 86bbb45f9d91b4098a262e3e50a793f3bb39497e

> 
> Diff: https://reviews.apache.org/r/39985/diff/
> 
> 
> Testing
> -------
> 
> This is the first in a chain of 5 patches. `make check` was used to test at the end of
the chain.
> 
> Note: documentation for these changes is included in https://reviews.apache.org/r/40271/
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message