mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 38110: Quota: Checked sanity of quota set requests.
Date Fri, 13 Nov 2015 09:58:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review106241
-----------------------------------------------------------


Will review this again after you refactor.


src/master/master.hpp (lines 879 - 898)
<https://reviews.apache.org/r/38110/#comment165133>

    Let's re-write this comment according to the sanity check we discussed with ben mahler
yesterday.
    It would be great to have the equation representing what we are checking for as part of
the comment.



src/master/master.hpp (lines 893 - 895)
<https://reviews.apache.org/r/38110/#comment165005>

    some fixes in:
    ```
    Currently, we do not account neither static nor dynamic reservations in role's allcoation
    ```
    to:
    ```
    Currently, we do not account for static or dynamic reservations in a role's allocation
    ```


- Joris Van Remoortere


On Nov. 10, 2015, 7:02 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 7:02 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu,
and Michael Park.
> 
> 
> Bugs: MESOS-3074
>     https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Performs a check whether a quota request is reasonable and can be satisfied at the moment.
A precise answer is impossible here, but a sanity check is still helpful, because it allows
us to filter knowingly unsatisfiable requests.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message