mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 39276: Fixed a bug in which under certains circumstances HTTP 1.1 Pipelining is not respected.
Date Thu, 12 Nov 2015 10:01:45 GMT


> On Nov. 10, 2015, 1:52 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2342
> > <https://reviews.apache.org/r/39276/diff/10/?file=1121241#file1121241line2342>
> >
> >     No pointer +  std::move.

The pointer is needed for a follow up patch, since it is passed to a lambda and C++11 doesn't
allow for rvalue references in lambdas (C++14 do though).


> On Nov. 10, 2015, 1:52 p.m., Alexander Rojas wrote:
> > 3rdparty/libprocess/src/process.cpp, lines 2339-2341
> > <https://reviews.apache.org/r/39276/diff/10/?file=1121241#file1121241line2339>
> >
> >     if we do move, remove this comment.

See below.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39276/#review105821
-----------------------------------------------------------


On Nov. 10, 2015, 4:58 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39276/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 4:58 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3705
>     https://issues.apache.org/jira/browse/MESOS-3705
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When using the same socket to send multiple HTTP requests to different actors. If the
actor responsible for handling the first request is stuck handling another event while a subsequent
request can reply immediatly, the order of the responses is altered violating HTTP Pipelining.
> 
> This patch fixes that problem enforcing that every response is sent in the order the
corresponding request arrived. It also adds a test to reproduce the issue and verify the fix
works.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/event.hpp 16ddbd77afa6efdf6bad201aa497ee102aa863ae

>   3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
>   3rdparty/libprocess/src/tests/http_tests.cpp 7eb4ef187b2cb358c370d0381db65b8e18668bab

> 
> Diff: https://reviews.apache.org/r/39276/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message