mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 40054: Fix fetch parsing problem for URL with query.
Date Sun, 08 Nov 2015 07:18:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40054/
-----------------------------------------------------------

(Updated Nov. 8, 2015, 7:18 a.m.)


Review request for mesos, Bernd Mathiske and Ben Mahler.


Changes
-------

Rebase


Bugs: MESOS-3367
    https://issues.apache.org/jira/browse/MESOS-3367


Repository: mesos


Description
-------

Fix fetch parsing problem for URL with query.


Diffs (updated)
-----

  src/slave/containerizer/fetcher.cpp 0b676f43e8529c6790824c8cf82e21a81d885ef1 
  src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 

Diff: https://reviews.apache.org/r/40054/diff/


Testing
-------

# Add `FetcherTest.OSNetUriWithQueryTest` test case.
# @bernd-mesos, @bmahler We could do a quick wround in old code. But I think add a parsing
function for URL maybe better, it also could fix the TODO item. I think we also could update
the code in fetcher to use process::http::URL, so far I only change the Fetcher::basename
function.


Thanks,

haosdent huang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message