mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 40017: Add Docker Image type to Container Image for v1 API.
Date Fri, 06 Nov 2015 19:59:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40017/#review105503
-----------------------------------------------------------

Ship it!



include/mesos/v1/mesos.proto (lines 1279 - 1280)
<https://reviews.apache.org/r/40017/#comment164118>

    It looks like the equivalent of this comment in `include/mesos/mesos.proto` still contains
an old TODO that has already been removed here. Would it be appropriate to clean up that TODO
in this review as well?


- Greg Mann


On Nov. 6, 2015, 12:16 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40017/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 12:16 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-2851
>     https://issues.apache.org/jira/browse/MESOS-2851
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Review 37196 added the Docker image type to the old API, this review does the same for
the v1 API.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a 
> 
> Diff: https://reviews.apache.org/r/40017/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message