mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <>
Subject Re: Review Request 40011: Mesos: Corrected style of Makefiles.
Date Fri, 06 Nov 2015 16:22:36 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 6, 2015, 4:22 p.m.)

Review request for mesos and Till Toenshoff.


Rebased, run distcheck.

Repository: mesos


This is not a full standartization of Makefile format, however, it is a step towards consistency.
This patch focuses mainly on the order of files and corrects obvious issues. These are guidelines
behind the change:

- Files in the same folder should appear in lexicographical order.
- Subfolders should appear in lexicographical order either after files or mixed with them
(depending on the current consensus in the file).
- Though tabs are preferred, spaces are not replaced if they are current consensus in the
file or current section.

Diffs (updated)

  src/ f0715386732b93936de6c8524957c6a6726fe9df 


Testing (updated)

make check (Mac OS X 10.10.4)
make distcheck (CentOS 7.1.1503)


Alexander Rukletsov

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message