mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 39991: fetcher should extract from .tar archive
Date Fri, 06 Nov 2015 10:48:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39991/#review105404
-----------------------------------------------------------



src/tests/fetcher_tests.cpp (line 542)
<https://reviews.apache.org/r/39991/#comment163990>

    Comment should end in punctuation. Add a `.` at the end.



src/tests/fetcher_tests.cpp (line 548)
<https://reviews.apache.org/r/39991/#comment163991>

    Unnecessary blank line



src/tests/fetcher_tests.cpp (lines 553 - 554)
<https://reviews.apache.org/r/39991/#comment163992>

    Where did you pull this TODO from? Should it remain a benh TODO or do you want to own
it?


- Adam B


On Nov. 5, 2015, 11:46 a.m., Bhuvan Arumugam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39991/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 11:46 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: mesos-2935
>     https://issues.apache.org/jira/browse/mesos-2935
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> fetcher should extract from .tar archive
> 
> 
> Diffs
> -----
> 
>   src/launcher/fetcher.cpp 8fb6c83981a141df9c0a8a6f8267230bef64f218 
>   src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 
> 
> Diff: https://reviews.apache.org/r/39991/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bhuvan Arumugam
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message