mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 39452: MESOS-3566 Description of RecordIO format
Date Fri, 06 Nov 2015 08:53:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39452/#review105385
-----------------------------------------------------------

Ship it!


Please verify your test results from rendering the website and then I'll commit this.


docs/scheduler-http-api.md (line 27)
<https://reviews.apache.org/r/39452/#comment163968>

    "[below][subscribe]" Have you rendered this on the website to see if this kind of link
still works? This has gotten even easier now that the website itself is included in the git
source.
    Please mention your test results from rendering the doc on the website in the "Testing
Done" section.



docs/scheduler-http-api.md (line 31)
<https://reviews.apache.org/r/39452/#comment163969>

    s/to be/would be/? or "is"?



docs/scheduler-http-api.md (lines 37 - 38)
<https://reviews.apache.org/r/39452/#comment163970>

    I don't think you necessarily need the actual line break in your definition, since you're
encoding it as "LF", so I would suggest:
    `record      = record-size LF record-data`


- Adam B


On Nov. 5, 2015, 3:50 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39452/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 3:50 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3566
>     https://issues.apache.org/jira/browse/MESOS-3566
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added the description of the RecordIO format to the HTTP API
> document with example code (Python) to decode.
> 
> 
> Diffs
> -----
> 
>   docs/scheduler-http-api.md de6cfc9e009a857ca45291b2dadce2a3b8199787 
> 
> Diff: https://reviews.apache.org/r/39452/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message