mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 38000: Added an API for libprocess users to interact with http::AuthenticatorManager
Date Wed, 04 Nov 2015 11:28:07 GMT


> On Oct. 21, 2015, 2:12 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/include/process/process.hpp, line 83
> > <https://reviews.apache.org/r/38000/diff/9/?file=1102349#file1102349line83>
> >
> >     Why aren't we using shared pointers here?

Last time I asked, we don't use std smart pointers on public stout and libprocess API's but
we are allowed to use them in internal code.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38000/#review103391
-----------------------------------------------------------


On Nov. 4, 2015, 12:27 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38000/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2015, 12:27 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3233
>     https://issues.apache.org/jira/browse/MESOS-3233
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds functions which allows libprocess users to add handlers which require authentication
as well as functions to install and remove authenticators.
> 
> Includes tests.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/process.hpp 8b086f296c80a43be2edaf496a04dadf0c64251a

>   3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
>   3rdparty/libprocess/src/tests/http_tests.cpp 7eb4ef187b2cb358c370d0381db65b8e18668bab

> 
> Diff: https://reviews.apache.org/r/38000/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message