mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 39923: Cleaned up configuration.md.
Date Wed, 04 Nov 2015 02:39:54 GMT


> On 十一月 4, 2015, 12:29 a.m., Guangya Liu wrote:
> > docs/configuration.md, line 792
> > <https://reviews.apache.org/r/39923/diff/1/?file=1115294#file1115294line792>
> >
> >     Why remove this?
> 
> Greg Mann wrote:
>     The text already states "A path to a file containing either one of the above options.",
and I thought that it makes this line a bit redundant.

Fair enogh. Thanks.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39923/#review105018
-----------------------------------------------------------


On 十一月 4, 2015, 12:16 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39923/
> -----------------------------------------------------------
> 
> (Updated 十一月 4, 2015, 12:16 a.m.)
> 
> 
> Review request for mesos, Jojy Varghese, Joris Van Remoortere, and Kapil Arya.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Edited configuration.md for style and consistency. Made consistent use of <code></code>
for commands, flags, and flag values. Edited the libprocess flags for consistency and proper
use of `=DIR` or `[=DIR]` depending on whether or not the directory is an optional parameter.
Note that the libprocess `--with-*` flags have two different descriptions depending upon whether
or not the library is bundled with Mesos.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 195814cf918e018d8287113299163415b94ab09f 
> 
> Diff: https://reviews.apache.org/r/39923/diff/
> 
> 
> Testing
> -------
> 
> Viewed with the mesos website container (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message