mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 39837: Passing os environment variables when start docker executor.
Date Mon, 02 Nov 2015 02:12:42 GMT


> On Nov. 1, 2015, 4:29 p.m., Timothy Chen wrote:
> > src/slave/containerizer/docker.cpp, line 302
> > <https://reviews.apache.org/r/39837/diff/1/?file=1113691#file1113691line302>
> >
> >     We intentionally exclude os enviornments as you can see here for a reason.
> >     
> >     There are a lot of environment variables that are default to the OS, that will
break when docker containers run and we need to not include them unless it's specifically
specified by the user with executor environement variables or taskinfo.
> >     
> >     The fix should be carefully picking the ones we need only.
> 
> haosdent huang wrote:
>     How about only include `MESOS_` and `LIBPROCESS_` prefix environment variables default?
> 
> Jojy Varghese wrote:
>     In this particular case, it looks like we DONT include the SSL environment variables
in the executor process which breaks it. So maybe we can address this particular issue for
now by adding SSL env variables. Also we need a better way to express the idea of adding specific
environment variables in the executor process(maybe something like a "include" and "exclude"
filters)

Agree. So let me change to only include SSL environment variables.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39837/#review104660
-----------------------------------------------------------


On Nov. 1, 2015, 9:38 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39837/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 9:38 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3815
>     https://issues.apache.org/jira/browse/MESOS-3815
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Passing os environment variables when start docker executor.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp 5e5e0f93123b7f0bda6c8afeb4df271e796e4637 
> 
> Diff: https://reviews.apache.org/r/39837/diff/
> 
> 
> Testing
> -------
> 
> manually test.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message