mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39250: Puller refactor: moved untar to a common place
Date Sun, 01 Nov 2015 15:50:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39250/#review104658
-----------------------------------------------------------


Bad patch!

Reviews applied: [39838, 39832, 39839, 38579, 39015, 39016, 39017, 39053, 39112, 39340, 39840,
38580]

Failed command: ./support/apply-review.sh -n -r 38580

Error:
 2015-11-01 15:50:03 URL:https://reviews.apache.org/r/38580/diff/raw/ [36966/36966] ->
"38580.patch" [1]
Successfully applied: Added docker registry RemotePuller

Integrated remote puller with store. Tests will follow.


Review: https://reviews.apache.org/r/38580
Checking 12 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp:548:  Redundant blank
line at the start of a code block should be deleted.  [whitespace/blank_line] [2]
Total errors found: 1
Failed to commit patch

- Mesos ReviewBot


On Nov. 1, 2015, 3:39 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39250/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2015, 3:39 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Puller refactor: moved untar to a common place
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp f314f20d989ed0125e15d2a14d0f8e56c56976d5

>   src/slave/containerizer/mesos/provisioner/docker/puller.hpp 8010b8aa75a2fc2e4b537f915f9dca028e407b63

>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp f61f9e5e9e97a771a03b75ff17cfcd3e3ecbc9b2

>   src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39250/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message