Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2920A18F1A for ; Wed, 28 Oct 2015 22:14:24 +0000 (UTC) Received: (qmail 49144 invoked by uid 500); 28 Oct 2015 22:14:17 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 49119 invoked by uid 500); 28 Oct 2015 22:14:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 49104 invoked by uid 99); 28 Oct 2015 22:14:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Oct 2015 22:14:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DF6C02A7AB7; Wed, 28 Oct 2015 22:14:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0412939992016721652==" MIME-Version: 1.0 Subject: Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`. From: "Joris Van Remoortere" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Joseph Wu" Cc: "Alex Clemmer" , "mesos" Date: Wed, 28 Oct 2015 22:14:16 -0000 Message-ID: <20151028221416.22462.87657@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Joris Van Remoortere" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39383/ X-Sender: "Joris Van Remoortere" References: <20151027064151.22462.85731@reviews.apache.org> In-Reply-To: <20151027064151.22462.85731@reviews.apache.org> Reply-To: "Joris Van Remoortere" X-ReviewRequest-Repository: mesos --===============0412939992016721652== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/#review104348 ----------------------------------------------------------- Ship it! 3rdparty/libprocess/3rdparty/stout/include/Makefile.am (lines 80 - 86) order 3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp (line 24) `` 3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp (line 46) new line - Joris Van Remoortere On Oct. 27, 2015, 6:41 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39383/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 6:41 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am ba2836a72ceee948cb43364e80ada9f132f33d04 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 7f70c9ea7d57634b5bfd40523ba37561ec92a09a > 3rdparty/libprocess/3rdparty/stout/include/stout/os/constants.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39383/diff/ > > > Testing > ------- > > CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10. > > Autotools `make check` on Ubuntu 15. > > > Thanks, > > Alex Clemmer > > --===============0412939992016721652==--