Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D01B1106D2 for ; Fri, 23 Oct 2015 17:21:32 +0000 (UTC) Received: (qmail 56063 invoked by uid 500); 23 Oct 2015 17:21:32 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 56040 invoked by uid 500); 23 Oct 2015 17:21:32 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 56023 invoked by uid 99); 23 Oct 2015 17:21:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Oct 2015 17:21:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1F48F2787C8; Fri, 23 Oct 2015 17:21:32 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1619816475480972996==" MIME-Version: 1.0 Subject: Re: Review Request 39518: Changed write api. From: "Jojy Varghese" To: "Timothy Chen" Cc: "Jojy Varghese" , "Benjamin Bannier" , "mesos" Date: Fri, 23 Oct 2015 17:21:32 -0000 Message-ID: <20151023172132.1655.3452@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Jojy Varghese" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39518/ X-Sender: "Jojy Varghese" References: <20151023075918.1655.52804@reviews.apache.org> In-Reply-To: <20151023075918.1655.52804@reviews.apache.org> Reply-To: "Jojy Varghese" X-ReviewRequest-Repository: mesos --===============1619816475480972996== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Oct. 23, 2015, 7:59 a.m., Benjamin Bannier wrote: > > src/slave/containerizer/provisioner/docker/registry_client.cpp, line 642 > > > > > > Wouldn't this potentially cause data loss if the called `write` function cannot dump everything in the `fd`? Good point. Didnt realize that write could return unfinished. Addressed in https://reviews.apache.org/r/39340/ - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39518/#review103739 ----------------------------------------------------------- On Oct. 21, 2015, 6:13 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39518/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 6:13 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-3773 > https://issues.apache.org/jira/browse/MESOS-3773 > > > Repository: mesos > > > Description > ------- > > See MESOS-3773. > > Change: > io::write(fd, string) has been having issues with junk being written to the > file. Using io::write(fd, void*, size_t) does not have this issue. > > > Diffs > ----- > > src/slave/containerizer/provisioner/docker/registry_client.cpp 24aa95c5800ff4dfb37465b71421b014b5dd5998 > > Diff: https://reviews.apache.org/r/39518/diff/ > > > Testing > ------- > > Make check. > > > Thanks, > > Jojy Varghese > > --===============1619816475480972996==--