Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0E7E810099 for ; Tue, 20 Oct 2015 08:23:18 +0000 (UTC) Received: (qmail 29439 invoked by uid 500); 20 Oct 2015 08:23:17 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 29407 invoked by uid 500); 20 Oct 2015 08:23:17 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 29391 invoked by uid 99); 20 Oct 2015 08:23:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 20 Oct 2015 08:23:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 53759278165; Tue, 20 Oct 2015 08:23:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8668805920963458298==" MIME-Version: 1.0 Subject: Re: Review Request 39457: Document messages in messages.proto. From: "Guangya Liu" To: "Artem Harutyunyan" , "Joris Van Remoortere" Cc: "Joseph Wu" , "Guangya Liu" , "mesos" Date: Tue, 20 Oct 2015 08:23:17 -0000 Message-ID: <20151020082317.1667.27674@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Guangya Liu" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39457/ X-Sender: "Guangya Liu" References: <20151020004224.32264.66349@reviews.apache.org> In-Reply-To: <20151020004224.32264.66349@reviews.apache.org> Reply-To: "Guangya Liu" X-ReviewRequest-Repository: mesos --===============8668805920963458298== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39457/#review103218 ----------------------------------------------------------- src/messages/messages.proto (line 77) s/from the agent up to the framework/from the agent to the framework ? src/messages/messages.proto (lines 123 - 128) Seems it is OK to remove this as I did not see anyone who is using it. If this removed, then the master also needs to be updated by removing such message. src/messages/messages.proto (line 139) s/sent/sends? src/messages/messages.proto (line 153) s/sent/sends? src/messages/messages.proto (line 413) s/slave/agent and other places? src/messages/messages.proto (lines 499 - 500) s/slave/agent src/messages/messages.proto (line 508) s/slave/agent src/messages/messages.proto (line 527) s/slave/agent src/messages/messages.proto (line 546) s/slave/agent src/messages/messages.proto (line 603) What about make all of the comments using same tone? For example: Notifies the scheduler about terminated executors. Ditto as following src/messages/messages.proto (line 640) Not only the agent but also all of the frameworks on the agent will be shutdown, can we put this in the document? src/messages/messages.proto (line 665) s/faiure/failure - Guangya Liu On 十月 20, 2015, 12:42 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39457/ > ----------------------------------------------------------- > > (Updated 十月 20, 2015, 12:42 a.m.) > > > Review request for mesos, Artem Harutyunyan and Joris Van Remoortere. > > > Bugs: MESOS-3759 > https://issues.apache.org/jira/browse/MESOS-3759 > > > Repository: mesos > > > Description > ------- > > A brief summary of each message was added. > > For messages with an associated Event/Call API object, a reference to the object was added. > Additionally, there is a great deal of documentation overlap between these messages and the comments in mesos/scheduler.hpp and v1/scheduler/scheduler.proto. Where necessary, some notes were added about the backwards compatibility of messages which are not instantiated in the code base. > > > Diffs > ----- > > src/messages/messages.proto ea9a67e169a8a359a12be93b804783c7dcced0b7 > > Diff: https://reviews.apache.org/r/39457/diff/ > > > Testing > ------- > > None. (Comment change only) > > > Thanks, > > Joseph Wu > > --===============8668805920963458298==--