Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 72DFE1810E for ; Mon, 19 Oct 2015 23:27:49 +0000 (UTC) Received: (qmail 53094 invoked by uid 500); 19 Oct 2015 23:27:49 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 53072 invoked by uid 500); 19 Oct 2015 23:27:49 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 53047 invoked by uid 99); 19 Oct 2015 23:27:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Oct 2015 23:27:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id E5D3E277E15; Mon, 19 Oct 2015 23:27:46 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3017898410586684364==" MIME-Version: 1.0 Subject: Re: Review Request 39381: CMake: Added protobuf and `slave/flags.cpp` to Windows builds. From: "Alex Clemmer" To: "Artem Harutyunyan" , "Joris Van Remoortere" , "Joseph Wu" Cc: "Alex Clemmer" , "mesos" Date: Mon, 19 Oct 2015 23:27:46 -0000 Message-ID: <20151019232746.32264.32943@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Alex Clemmer" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/39381/ X-Sender: "Alex Clemmer" References: <20151016195048.1509.97449@reviews.apache.org> In-Reply-To: <20151016195048.1509.97449@reviews.apache.org> Reply-To: "Alex Clemmer" X-ReviewRequest-Repository: mesos --===============3017898410586684364== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39381/ ----------------------------------------------------------- (Updated Oct. 19, 2015, 11:27 p.m.) Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu. Bugs: MESOS-3610 https://issues.apache.org/jira/browse/MESOS-3610 Repository: mesos Description ------- CMake: Added protobuf and `slave/flags.cpp` to Windows builds. Diffs (updated) ----- src/CMakeLists.txt c85bddbda3a17b45d7e31517ddf70358ebde1b41 Diff: https://reviews.apache.org/r/39381/diff/ Testing ------- CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10. Autotools `make check` on Ubuntu 15. Thanks, Alex Clemmer --===============3017898410586684364==--