Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A0BAA18427 for ; Mon, 19 Oct 2015 18:50:15 +0000 (UTC) Received: (qmail 37127 invoked by uid 500); 19 Oct 2015 18:49:41 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 37105 invoked by uid 500); 19 Oct 2015 18:49:41 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 37087 invoked by uid 99); 19 Oct 2015 18:49:41 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Oct 2015 18:49:41 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id DDE60277CFE; Mon, 19 Oct 2015 18:49:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2386470047436937257==" MIME-Version: 1.0 Subject: Re: Review Request 38117: Export per container SNMP statistics From: "Cong Wang" To: "Vinod Kone" , "Jie Yu" , "Paul Brett" Cc: "Cong Wang" , "haosdent huang" , "mesos" , "Ian Downes" , "Mesos ReviewBot" Date: Mon, 19 Oct 2015 18:49:38 -0000 Message-ID: <20151019184938.32263.21224@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Cong Wang" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38117/ X-Sender: "Cong Wang" References: <20150908211259.1695.484@reviews.apache.org> In-Reply-To: <20150908211259.1695.484@reviews.apache.org> Reply-To: "Cong Wang" X-ReviewRequest-Repository: mesos --===============2386470047436937257== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ ----------------------------------------------------------- (Updated Oct. 19, 2015, 6:49 p.m.) Review request for mesos, Jie Yu, Paul Brett, and Vinod Kone. Changes ------- Address review comments from Ian Bugs: MESOS-3365 https://issues.apache.org/jira/browse/MESOS-3365 Repository: mesos Description ------- These stats are those we get by `netstat -s`, they are important for diagnose networking issues. Diffs (updated) ----- include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a81aaaa1cf8002e src/slave/containerizer/isolators/network/port_mapping.hpp ae53c1b1716a7ad9c6e64f9079c972bae31e4ed2 src/slave/containerizer/isolators/network/port_mapping.cpp e6bb75e6f5ba48a0c4cf6dd8f353e5f5843d0eef src/slave/flags.hpp 3e93b52a5874f52361d5a9c685499a7032014a73 src/slave/flags.cpp 1bf394ea62fde29caa6705cd5d156eae452adbf2 Diff: https://reviews.apache.org/r/38117/diff/ Testing (updated) ------- ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics --pid=XXXX Thanks, Cong Wang --===============2386470047436937257==--