Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@mesos.apache.org
Content-Type: multipart/alternative;
 boundary="===============4738277802328389319=="
MIME-Version: 1.0
Subject: Re: Review Request 39384: Added docs for how developers should split
 their work into Git commits.
From: "Ben Mahler" <benjamin.mahler@gmail.com>
To: "Ben Mahler" <benjamin.mahler@gmail.com>
Cc: "Neil Conway" <neil.conway@gmail.com>, "mesos" <reviews@mesos.apache.org>
Date: Fri, 16 Oct 2015 18:28:50 -0000
Message-ID: <20151016182850.1509.52117@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Ben Mahler" <noreply@reviews.apache.org>
References: <20151016182103.1509.41432@reviews.apache.org>
In-Reply-To: <20151016182103.1509.41432@reviews.apache.org>
Reply-To: "Ben Mahler" <benjamin.mahler@gmail.com>

--===============4738277802328389319==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Oct. 16, 2015, 6:21 p.m., Ben Mahler wrote:
> > Thanks Neil! It looks like we have overlap between this and the effective code review doc here:
> > http://mesos.apache.org/documentation/latest/effective-code-reviewing/
> > 
> > Should we just link to this from the submitting a patch doc? Anything you think should be added / changed in the code review doc?
> 
> Neil Conway wrote:
>     Ah, I hadn't seen that -- I think overlap isn't the end of the world, and a lot of new contributors won't read the code-reviewing page. How about both adding some text to submitting-a-patch and also including a link to the code-reviewing page?

Sounds good.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39384/#review102955
-----------------------------------------------------------


On Oct. 16, 2015, 4:41 a.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39384/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 4:41 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added docs for how developers should split their work into Git commits.
> 
> 
> Diffs
> -----
> 
>   docs/submitting-a-patch.md cbd99fe3fd162703165933336700e3fc292243a9 
> 
> Diff: https://reviews.apache.org/r/39384/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


--===============4738277802328389319==--