Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 061571885C for ; Fri, 9 Oct 2015 04:52:32 +0000 (UTC) Received: (qmail 92763 invoked by uid 500); 9 Oct 2015 04:52:31 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 92740 invoked by uid 500); 9 Oct 2015 04:52:31 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 92722 invoked by uid 99); 9 Oct 2015 04:52:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Oct 2015 04:52:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 75E1328D973; Fri, 9 Oct 2015 04:52:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3602952629870106725==" MIME-Version: 1.0 Subject: Re: Review Request 38746: Added TaskStatus::Reason to containerizer Termination message. From: "Timothy Chen" To: "Vinod Kone" , "Ben Mahler" , "Timothy Chen" Cc: "Jie Yu" , "mesos" Date: Fri, 09 Oct 2015 04:52:30 -0000 Message-ID: <20151009045230.31883.33583@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Timothy Chen" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38746/ X-Sender: "Timothy Chen" References: <20151009012826.31883.74297@reviews.apache.org> In-Reply-To: <20151009012826.31883.74297@reviews.apache.org> Reply-To: "Timothy Chen" X-ReviewRequest-Repository: mesos --===============3602952629870106725== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38746/#review102006 ----------------------------------------------------------- include/mesos/mesos.proto (line 1119) What's the reasoning behind this order? src/slave/slave.cpp (line 4509) Should we say Executor preempted here? And also I wonder if we should stick with the Qos correction terminology here, e.g: Container preempted by QoS correction? - Timothy Chen On Oct. 9, 2015, 1:28 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38746/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 1:28 a.m.) > > > Review request for mesos, Ben Mahler, Timothy Chen, and Vinod Kone. > > > Bugs: MESOS-2035 > https://issues.apache.org/jira/browse/MESOS-2035 > > > Repository: mesos > > > Description > ------- > > Added TaskStatus::Reason to containerizer Termination message. > > The following doc summarized the problem and proposed a solution: > https://docs.google.com/document/d/1klGDAu5yBVf-CGWLqvELLIfxLfRaisGkhi6Gn7952-4/edit?usp=sharing > > > Diffs > ----- > > include/mesos/containerizer/containerizer.proto f16ccc89f83da28c413ccfa0687a06b7515a605c > include/mesos/mesos.proto 4a16be1f570769f3ce42a50a9da9f4fb1c227999 > include/mesos/slave/isolator.proto 9d38a25470a79af1eda9122c037c82b8cbbad6ed > src/common/protobuf_utils.hpp 8793851fb927ab1326da6b6a424b3c6a75eb5001 > src/common/protobuf_utils.cpp c1e8e011e6d0b8e1cd8a836e3168685ec401b21b > src/slave/containerizer/docker.cpp 6c975f904178e01797b67628a2d471ec7b3b1fbf > src/slave/containerizer/external_containerizer.cpp 211649201777f0d2ce802a865090129eacdd53be > src/slave/containerizer/isolators/cgroups/mem.cpp 89c86beb9227eb8a6e70a413e7b3934add652981 > src/slave/containerizer/isolators/posix/disk.cpp c324c79f8d598095d07fbcb26e806a0978c2a520 > src/slave/containerizer/mesos/containerizer.hpp 4c1419290645ad4c44360a81618a6cea7ad190df > src/slave/containerizer/mesos/containerizer.cpp b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 > src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476 > src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c > src/tests/containerizer.cpp 1f743155526192569dd61a47ab67d8e58aab205a > src/tests/containerizer/docker_containerizer_tests.cpp 8771ef661039310d79845513ea4602e15b2ad13d > src/tests/containerizer/mesos_containerizer_tests.cpp 5bc7d408bda0c249e1b66747d8bd87e688362e6c > src/tests/slave_recovery_tests.cpp fd285fbba0ec08fe2afbdd8da0b0b451126da0eb > src/tests/slave_tests.cpp dccdbb0ec5352df5da63d5ef7261bfc7fd599acb > > Diff: https://reviews.apache.org/r/38746/diff/ > > > Testing > ------- > > sudo make check > > tested with Docker as well. > > > Thanks, > > Jie Yu > > --===============3602952629870106725==--