Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 97C1517FFE for ; Tue, 6 Oct 2015 12:54:01 +0000 (UTC) Received: (qmail 69696 invoked by uid 500); 6 Oct 2015 12:54:01 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 69672 invoked by uid 500); 6 Oct 2015 12:54:01 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 69649 invoked by uid 99); 6 Oct 2015 12:54:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Oct 2015 12:54:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 2959D28D6D4; Tue, 6 Oct 2015 12:54:00 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6216542772993854375==" MIME-Version: 1.0 Subject: Re: Review Request 38337: Extract gz file in fetcher. From: "Bernd Mathiske" To: "Timothy Chen" , "Adam B" , "Bernd Mathiske" Cc: "mesos" , "haosdent huang" Date: Tue, 06 Oct 2015 12:54:00 -0000 Message-ID: <20151006125400.31884.97116@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bernd Mathiske" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/38337/ X-Sender: "Bernd Mathiske" References: <20151005092648.31884.16215@reviews.apache.org> In-Reply-To: <20151005092648.31884.16215@reviews.apache.org> Reply-To: "Bernd Mathiske" X-ReviewRequest-Repository: mesos --===============6216542772993854375== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38337/#review101641 ----------------------------------------------------------- I am wondering whether gzip is always available on all platforms. Can we rely on this? Even on CoreOS? And if we cannot, do we give an appropriate error message that is informative enough? - Bernd Mathiske On Oct. 5, 2015, 2:26 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38337/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 2:26 a.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, and Timothy Chen. > > > Bugs: MESOS-3407 > https://issues.apache.org/jira/browse/MESOS-3407 > > > Repository: mesos > > > Description > ------- > > Extract gz file in fetcher. > > > Diffs > ----- > > src/launcher/fetcher.cpp 0f1533a0d7dc453e143a15e988d04ca6e55446ff > src/tests/fetcher_tests.cpp 8d13352d0d3f8fb80581e7913c9416b543cfd009 > > Diff: https://reviews.apache.org/r/38337/diff/ > > > Testing > ------- > > sudo GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="FetcherTest.ExtractGzipFile" --verbose > > > Thanks, > > haosdent huang > > --===============6216542772993854375==--