mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 39383: Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.
Date Wed, 28 Oct 2015 22:14:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39383/#review104348
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/include/Makefile.am (lines 80 - 86)
<https://reviews.apache.org/r/39383/#comment162596>

    order



3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp (line 24)
<https://reviews.apache.org/r/39383/#comment162597>

    `<stout/error.hpp>`



3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp (line 46)
<https://reviews.apache.org/r/39383/#comment162598>

    new line


- Joris Van Remoortere


On Oct. 27, 2015, 6:41 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39383/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 6:41 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am ba2836a72ceee948cb43364e80ada9f132f33d04

>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 7f70c9ea7d57634b5bfd40523ba37561ec92a09a

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/constants.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39383/diff/
> 
> 
> Testing
> -------
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows
10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message