mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Isabel Jimenez" <cont...@isabeljimenez.com>
Subject Re: Review Request 38577: Added synchronous validation for Call in Agent
Date Tue, 27 Oct 2015 01:24:08 GMT


> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote:
> > src/slave/validation.hpp, line 31
> > <https://reviews.apache.org/r/38577/diff/8/?file=1108614#file1108614line31>
> >
> >     why space here?

Added it there after a review comment.


> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote:
> > src/slave/validation.cpp, line 75
> > <https://reviews.apache.org/r/38577/diff/8/?file=1108615#file1108615line75>
> >
> >     also print status.source()

We don't have a stringify for this.


> On Oct. 27, 2015, 1:13 a.m., Vinod Kone wrote:
> > src/tests/executor_http_api_tests.cpp, line 505
> > <https://reviews.apache.org/r/38577/diff/8/?file=1108616#file1108616line505>
> >
> >     make sure this pattern is consistent everywhere else in this file.

Inversed advise here, killed this and made sure above pattern is consistent everywhere.


- Isabel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38577/#review104123
-----------------------------------------------------------


On Oct. 27, 2015, 1:20 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38577/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 1:20 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-2906
>     https://issues.apache.org/jira/browse/MESOS-2906
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for Call protobuf message in Agent /api/v1/executor endpoint.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e6169a0 
>   src/Makefile.am e797dac 
>   src/slave/http.cpp 3f7f71b 
>   src/slave/validation.hpp PRE-CREATION 
>   src/slave/validation.cpp PRE-CREATION 
>   src/tests/executor_http_api_tests.cpp e429d84 
> 
> Diff: https://reviews.apache.org/r/38577/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message